Rationalise visual sample for Perl #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Perl sample contains large amounts of duplicative code. This commit simplifies the sample and better organises its sections.
|
@labster Not sure if you have any thoughts but I took the opportunity to clean up the Perl sample to remove the duplicative code that was in there. |
|
This is intended to just be a sample, not a program that does something. No need to declare every variable. LGTM 👍 |
|
Thanks @labster! Merged it in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Perl sample contains large amounts of duplicative code. This commit simplifies the sample and better organises its sections.