Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'MicrosoftShell' and 'MSShell' as alias for 'PowerShell' #1077

Merged
merged 1 commit into from
May 28, 2019

Conversation

ypid-geberit
Copy link
Contributor

PowerShell was previously called MS Shell. It might make sense to also support those aliases to not break backwards compatibility basically.

Ref: https://en.wikipedia.org/wiki/PowerShell

@pyrmont
Copy link
Contributor

pyrmont commented May 27, 2019

@ypid-geberit Sorry to have taken so long to get back to you. It took a while but we've got CI builds working again. Could you push an empty commit to kick off one with the new configuration? I'll be able to merge after that.

PowerShell was previously called MS Shell. It might make sense to also support those aliases to not break backwards compatibility basically.

Ref: https://en.wikipedia.org/wiki/PowerShell
@ypid-geberit
Copy link
Contributor Author

ypid-geberit commented May 28, 2019

Thanks for getting back and don’t worry about the delay.

Could you push an empty commit to kick off one with the new configuration?

I would propose another way to do this instead of the empty commit:

git commit --amend
git push --force

You don’t even need to change the commit message because when you do the amend commit, the commit timestamp will be updated which changes the commit hash.

Pushed and passing. Thanks for maintaining!

@pyrmont pyrmont merged commit 9e29a54 into rouge-ruby:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants