-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDScript language support #1036
Add GDScript language support #1036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's taken so long to get to this. Please feel free to ask if you have any questions!
@pyrmont I've put variables behind methods, but I am not sure about other issues. These rules are based on Pygments implementation, I'm neither Ruby developer nor regex guru :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments.
@pyrmont sorry for a long delay. I've tried to fix all the issues with the rules. |
@leonidboykov No worries. Thanks for all the work! There are 2 outstanding points:
|
@pyrmont I've committed fixes for that. |
@leonidboykov Thanks for going through all the back and forth with me and I'm sorry for all the mistakes during the code review. I made quite a bit of extra work for you :( On the positive side, it's great to have this lexer in Rouge! 🎉 We're currently on a two-week release cadence and the next release (3.7.0) will go out next Tuesday so this will very shortly be available as part of the gem. Thanks for making Rouge better for all its users :) |
Added support for Godot GDScript language. Mostly copied from Pygments and Chroma versions.
Resolves #1016 and gitlab-org/gitlab-ce#19663.
I've also pushed PR #1034 because Str::Affix is missing in rouge, but it is used in original lexers (I've used Str::Char as replacement).Update: replaced
Str::Char
withStr::Affix
.