Broken java highlighting

[nerro]

Hello,

I found that in java code some utf-8 symbols (like german umlauts) will be rendered as error (with red background text).
Example: http://rouge.jneen.net/pastes/eePb

I'll try to figure it out myself how to fix it.

[aalvrz]

Good catch.

However (and correct me if I am wrong), but you shouldn't really write code that contains special characters...

[dblessing]

It looks like any Unicode character is acceptable for Java identifiers. I’m not sure whether it’s good practice or not, but since it’s valid we should try to support it unless it’s prohibitively difficult. I’m guessing the offending regex uses \w somewhere. We could potentially switch to [[:alpha:]] to match any alphabetic character, not just 7-bit ones.

…

On Tue, Dec 5, 2017 at 4:56 PM Andrés Álvarez ***@***.***> wrote: Good catch. However (and correct me if I am wrong), but you shouldn't really write code that contains special characters... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#831 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACSKlBUk7p6s2J7-iewCsJu_LCTUQi0eks5s9coKgaJpZM4Q0d6Z> .

[nerro]

@BigChief45 , @dblessing, you both are right. Actually it's not good practice to write code like this, but sometimes you have to generate code for WSDL (https://en.wikipedia.org/wiki/Web_Services_Description_Language).

P.S. It maybe even worse 😄 instead of ß you can write \u00df.

[ew-git]

Just want to add that the Julia community uses a wide array of Unicode characters more frequently (certainly not bad practice!), so more robust support would be great.
https://docs.julialang.org/en/v1/manual/unicode-input/index.html
http://rouge.jneen.net/pastes/1NDV

Somewhat related issue: #934

Thank you all for your work on this project.

[stale]

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.

If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

[pyrmont]

Confirmed this is still occurring in v3.15.0. This should be something relatively easy to fix. I'll take a look.

[jneen]

Comes down to these:

      id = /[a-zA-Z_][a-zA-Z0-9_]*/
      const_name = /[A-Z][A-Z0-9_]*\b/
      class_name = /[A-Z][a-zA-Z0-9]*\b/

Replace them with [:upper:] and [:lower:] and it should work out

[pyrmont]

Thanks @jneen! Will submit a bug fix soon!