Another iOS memory leak #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NP will wait some days for next release. Keep them coming 😀 |
|
@roubachof you're good to pull it in. I think we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #112 fixed an iOS memory leak that would manifest itself if even an empty
CollectionViewwas added to a view. Unfortunately, this wasn't the only leak on the iOS side.This PR also addresses #56 . Once items are added to a
CollectionView, a separate leak occurs. This leak can be avoided by rearranging the order in which platform objects are disposed inCleanUp().@roubachof I think there might be one or two more leaks on the iOS side. If so, expect another PR or two in the next few days.