Skip to content

Commit

Permalink
CMake: use enable_testing() instead of include(CTest)
Browse files Browse the repository at this point in the history
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 ,
using include(CTest) adds unnecessary clutter that is only needed for
dashboard submission. enable_testing() is enough otherwise

"Port" of OSGeo/shapelib#162
  • Loading branch information
rouault committed Oct 25, 2024
1 parent 95cce30 commit 809da3a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ include(cmake/helpers/GdalCMakeMinimumRequired.cmake)
cmake_minimum_required(VERSION ${GDAL_CMAKE_VERSION_MIN}...${GDAL_CMAKE_VERSION_MAX})

project(gdal LANGUAGES C CXX)
include(CTest)

set(GDAL_LIB_TARGET_NAME GDAL)

Expand Down Expand Up @@ -224,6 +223,9 @@ endif()
#
include(${CMAKE_CURRENT_SOURCE_DIR}/gdal.cmake)

if (BUILD_TESTING)
enable_testing()
endif()
if (BUILD_TESTING AND EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/autotest")
# unit tests
add_subdirectory(autotest/cpp)
Expand Down

0 comments on commit 809da3a

Please sign in to comment.