Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @kusto/language-service-next #127

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

rosshamish
Copy link
Owner

@rosshamish rosshamish commented Apr 27, 2024

Update @kusto/language-service-next to the 11.5.* line, which was published 3 months ago and is getting regular updates. This dependency was previously pinned to an old pre-release version (0.0.28-rc.1) which was used during the original hackathon back in 2019 that this extension was created during.

Fixes bug #5
Also fixes bug #126 in passing.

Additional changes:

  • some updates to deal with some breaking changes made to types - nothing too scary, mostly types getting upgraded to be nullable, or constructors changing order and therefore changing names
  • remove hand-written type definitions that were needed to get the typescript build passing (e.g. kusto-language-server/server/out/Kusto.Language.Bridge.min.js)
  • remove peer dependencies that were needed to patch things up back then (the legacy language service package, the monaco package). These are no longer needed anymore - everything is included in the latest language service package.
  • update the typescript version in use to 5.* - this is parity with the Azure/monaco-kusto package, which is a more well-supported sibling of this one and is worth referring to.
  • update the node version used in CI to 20 (was: 12)
  • update @types/node, needed for CI to pass during npm run vscode:prepublish, see https://stackoverflow.com/questions/57331779/typescript-duplicate-identifier-iteratorresult

Testing:

@rosshamish rosshamish marked this pull request as ready for review April 27, 2024 21:20
@rosshamish rosshamish merged commit 8f75079 into master Apr 27, 2024
1 check passed
@rosshamish rosshamish deleted the user/rosshamish/format-bug-126 branch April 27, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant