Fix bugs in pytuya #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rospogrigio
approved these changes
Oct 19, 2020
| @@ -537,7 +543,7 @@ def _generate_payload(self, command, data=None): | |||
| json_data["dps"] = self.dps_to_request | |||
|
|
|||
| payload = json.dumps(json_data).replace(" ", "").encode("utf-8") | |||
| self.log.debug("Paylod: %s", payload) | |||
| self.log.debug("Send paylod: %s", payload) | |||
There was a problem hiding this comment.
Tested with my official environment and everything works. Just this little typo we might want to correct (paylod).
There was a problem hiding this comment.
Certainly! Fixed now.
This handles responses without a return code and also fixes support for unencrypted clients. Made a few tweaks to debug logs as well.
postlund
force-pushed
the
pytuya_fixes
branch
from
e98c4a6 to
dbe25d8
Compare
|
Merged #92. |
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles responses without a return code and also fixes support for
unencrypted clients. Made a few tweaks to debug logs as well.