Re-port changes from PR 491, this fixes lights with internet connection #817
Conversation
lloydw
changed the title
|
Hope it get merged soon, waiting for this to finally fix the zombie light issues! |
|
This seems to have stopped working today, so I'm going to need to look into it further. |
|
Reopening with a proper solution |
lloydw
changed the title
lloydw
changed the title
| @@ -487,6 +503,15 @@ async def heartbeat(self): | |||
| """Send a heartbeat message.""" | |||
| return await self.exchange(HEARTBEAT) | |||
|
|
|||
| async def reset(self): | |||
There was a problem hiding this comment.
This broadly makes sense. The version of pytuya here has been actively maintained in other projects like https://github.com/jasonacox/tinytuya/blob/master/tinytuya/__init__.py - did you want to take a quick look and see if they've solved similar issues; and if so, is there anything you'd backport here?
There was a problem hiding this comment.
Thanks for the feedback! I took a brief look at the linked code but it seems quite different and I didn’t see any logic for this particular issue.
I’ll look at updating this branch with the v4 updates and ensure it all works
|
This is killing my ability to use the custom component, any update getting this merged? |
This was originally merged, but the changes caused some issues with some other devices, so I changed the logic to allow it to be selectively enabled. Unfortunately this fix also introduced a bug, which should be fixed in PR #1273 . Do you want to try that PR and see if that helps? |
Thanks for the suggestion, unfortunately it didn't change anything :( |
Which part of this change isn't working for you? |
I copied in the code from your PR but I was still not able to get values back from the plugs, such as energy details or even its status as before. Interestingly, I did discover I'm able to use the turn on and turn off services to manipulate the device, I just get no response back. Perhaps this is something else? |
My DETA Grid Connect lights do not initialize properly if they don't have internet access, this was fixed by @Elendilon in this PR #491, but it is getting a few revisions behind.
I have re-ported the changes from that PR onto the latest code with this. It works with my switches, lights and sockets