Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract shared code into a common module #46

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Extract shared code into a common module #46

merged 1 commit into from
Sep 24, 2020

Conversation

postlund
Copy link
Collaborator

The purpose of this refactor is to remove circular dependencies between the platforms and main module, as this causes problems when implementing #40.

@postlund postlund changed the title Extract shares code into a common module Extract shared code into a common module Sep 23, 2020
rospogrigio
rospogrigio reviewed Sep 24, 2020
View reviewed changes
Copy link
Owner

@rospogrigio rospogrigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added just some slight comments.
I still have the Cryptodome/Crypto issue, don't know if it's the proper PR to fix that.

custom_components/localtuya/__init__.py Show resolved Hide resolved
custom_components/localtuya/common.py Outdated Show resolved Hide resolved
custom_components/localtuya/common.py Outdated Show resolved Hide resolved
@postlund
Copy link
Collaborator Author

postlund commented Sep 24, 2020 •
edited
Loading

Comments should be solved now.

@postlund postlund merged commit fefee69 into master Sep 24, 2020
@postlund postlund deleted the refactor branch September 24, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rospogrigio rospogrigio rospogrigio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postlund @rospogrigio