Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pull_request_target from ci workflow #42

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Remove pull_request_target from ci workflow #42

merged 1 commit into from
Sep 22, 2020

Conversation

postlund
Copy link
Collaborator

No description provided.

postlund referenced this pull request in mileperhour/localtuya-homeassistant Sep 22, 2020
@postlund
Initial step to have continuous integration
30392d3 
This commit introduces the use of tox, which currently only verifies
that code is formatted according to the black project. More checks will
come in upcoming PRs for codespell, pydocstyle, flake8 and mypy.

A GitHub actions is included that runs tox on new pull requests, so we
get automatic feedback and can block commits that fail any check.
Another (official) action that runs hassfest is included as well, to
make sure we are compatible with Home Assistant.
@postlund postlund merged commit ec7652b into master Sep 22, 2020
@postlund postlund deleted the fix_gh branch September 22, 2020 10:41
@rospogrigio
Copy link
Owner

Just created a new PR (rospogrigio#42), anything strange there?

Nope, this PR works fine here.

@rospogrigio
Copy link
Owner

Ehi, I see the automatic Checks... how does this work? How can we run this for #40?

@postlund
Copy link
Collaborator Author

The checks are run automatically on all pull requests and all updates to them, e.g. if you push new commits. Old pull requests might be in a limbo though. You can try pushing something to #40 to see if it gets picked up.

The CI workflow is triggers by this line and you can also see what is done for that workflow:

https://github.com/rospogrigio/localtuya-homeassistant/blob/ec7652b19382c4bc0d43843c7dedb5bcc31c17a6/.github/workflows/ci.yaml#L3

One thing you can do now is to go to Settings -> Branches and press Edit next to the master branch. Here you can tick Require status checks to pass before merging, Require branches to be up to date before merging, all the status checks in the list and Require linear history. This will prevent merged if checks fail. It could be interesting to use Require pull request reviews before merging as that requires at least one of us to look and press approve at a PR before merging. It can be kinda good to prevent hasty merging of stuff.

@rospogrigio
Copy link
Owner

Done 👍

@postlund
Copy link
Collaborator Author

Great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postlund @rospogrigio