Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: spring cleaning #185

Merged
merged 13 commits into from
Jan 7, 2024
Merged

feat!: spring cleaning #185

merged 13 commits into from
Jan 7, 2024

Conversation

mvllow
Copy link
Member

@mvllow mvllow commented Nov 27, 2023

Includes release notes for v2.0.0-next.1

Please provide feedback in the related discussion: #195

Closes #131 #172 #183 #184 #191

mvllow added 4 commits January 2, 2024 20:31
This commit reverts the high contrast Visual highlights in favour of
the previous, neutral behaviour. This allows the foreground highlights
to remain even when selected. Use the previous version in your own
configuration:

```lua
highlight_groups = {
  Visual = { fg = "base", bg = "pine" }
}
```
@mvllow mvllow merged commit b776a47 into main Jan 7, 2024
@mortezadadgar
Copy link
Contributor

Would it be better to enable extend_background_behind_borders by default? I understand new releases can have breaking changes but I think this will come surprising to users when they found out telescope window has disjointed background colors
image

@mvllow
Copy link
Member Author

mvllow commented Jan 7, 2024

I don’t mind setting that to true by default. Will update later today :)

For other feedback please add to the related discussion: #195

pcattori added a commit to pcattori/dotfiles that referenced this pull request Jan 8, 2024
also update reference to rose-pine `utils` -> `utilities`
see rose-pine/neovim#185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: gitsigns background is not transparent when disable_background is set RFC: Options and groups
3 participants