Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo and grammar fixed, Bonus: clarifying the option effect #175

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

HectorOvid
Copy link
Contributor

Trying to make the description in the readme regarding options for highlighting better.

@HectorOvid HectorOvid closed this Jul 21, 2023
@HectorOvid HectorOvid reopened this Jul 21, 2023
@HectorOvid
Copy link
Contributor Author

k

@mvllow
Copy link
Member

mvllow commented Jul 21, 2023

Oh, I actually don't think that documentation was meant to be there—we ended up going a different direction:

if (opts.inherit == nil or opts.inherit) and default_opts ~= nil then -- On merge.

Feel free to document that new option if you'd like (related PR) :)

We can remove the other option from the readme.

Add an example for the inherit highlight config.
@HectorOvid
Copy link
Contributor Author

Ya, the option is not used any more :D in code
i removed the mention in readme

Is Search a good example for the inherit usage? Not quite sure since i'm pretty new to nvim and its plugins

@mvllow
Copy link
Member

mvllow commented Jul 22, 2023

Search could be good, anything that setting inherit to false would be useful for :)

@HectorOvid
Copy link
Contributor Author

not sure if you saw, I added an example with Search in a commit above.

U think this is expressive enough? :)

@mvllow mvllow merged commit e103407 into rose-pine:main Jul 22, 2023
@mvllow
Copy link
Member

mvllow commented Jul 22, 2023

Perfect, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants