Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make extent/size of floating windows clearer #129

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix: Make extent/size of floating windows clearer #129

merged 1 commit into from
Feb 24, 2023

Conversation

briandipalma
Copy link
Contributor

No description provided.

@briandipalma
Copy link
Contributor Author

This is what it looks like with my change:

border: "none"
image

border: "single"
image

border: "double"
image

border: "rounded"
image

border: "solid"
image

border: "shadow"
image

Custom border - the way I think Neovim should be by default for the single/double/rounded borders above
image

telescope
image

I'll post screenshots without my change next.

@briandipalma
Copy link
Contributor Author

This is what it looks like without the change:

border: "none" - no change
image

border: "single" - improvement as you can now see correct size of floating window
image

border: "double" - improvement as you can now see correct size of floating window
image

border: "rounded" - improvement as you can now see correct size of floating window
image

border: "solid" - improvement as you can now see correct size of floating window, really bad looking without the change
image

border: "shadow" - no change
image

Custom border - improvement, clearer definition of floating window
image

telescope - no change
image

@mvllow mvllow merged commit 4d6b2a2 into rose-pine:main Feb 24, 2023
@mvllow
Copy link
Member

mvllow commented Feb 24, 2023

Appreciate all the before/after screenshots as well as you changing the PR to work with the latest update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants