Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease up diff backgrounds #104

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Ease up diff backgrounds #104

merged 1 commit into from
Nov 9, 2022

Conversation

Slotos
Copy link
Contributor

@Slotos Slotos commented Nov 8, 2022

Lower the blend intensity to leave sufficient colour difference for the eye to catch on.

This changes
image
image

To
image
image

Red, grey, and green highlights are now readable on diff backgrounds, whereas before some text could become illegible.


Light variant is improved as well:

Before:
image

After:
image

@mvllow
Copy link
Member

mvllow commented Nov 8, 2022

Thanks for the PR! Happy to accept these changes as-is because it's quite the improvement, but curious if setting all the opacities to 0.2 looks good too? Just for consistency reasons.

Lower the blend intensity to leave sufficient colour difference for the eye to catch on.
@Slotos
Copy link
Contributor Author

Slotos commented Nov 9, 2022

IIRC 0.3 was my initial adjustment, and dropping to 0.2 made a sizeable difference for green background, especially green-on-green cases. Red worked ok and I just lazed out of adjusting it further.

I've force pushed an update. Comparison screenshots follow:

DiffDelete 0.3 blend:
image
image

DiffDelete 0.2 blend:
image
image

@mvllow mvllow merged commit bfc2aa0 into rose-pine:main Nov 9, 2022
@mvllow
Copy link
Member

mvllow commented Nov 9, 2022

Thanks again :) Really appreciate the before/after screenshots – makes my life much easier!

@Slotos Slotos deleted the patch-1 branch November 9, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants