Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for @* treesitter highlight groups #101

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

myuwi
Copy link
Contributor

@myuwi myuwi commented Oct 20, 2022

nvim-treesitter recently dropped support for the TS* highlight groups (See: nvim-treesitter/nvim-treesitter#3656) which broke Treesitter support for many themes, including this one.

I have added the corresponding @* highlight groups which should return the syntax highlights back to normal. The old TS* highlight groups can likely be removed in the future, but I have kept them untouched for now in case they are needed for backwards compatibility with older Treesitter versions.

Edit: It seems like these changes aren't 100% in line with the previous highlight groups, so some changes need to be made before this can be merged. TODO tags, for example, aren't using the iris color anymore.

@myuwi
Copy link
Contributor Author

myuwi commented Oct 20, 2022

I have rechecked the highlight groups and made some changes based on nvim-treesitter/nvim-treesitter@42ab95d and the Neovim Treesitter docs, and the highlight groups seem to be more in line with the previous ones now. I am still a little bit unsure if the groups are 100% correct, as I haven't been able to check everything, but they seem fine now.

@myuwi myuwi force-pushed the fix-treesitter-highlight-groups branch from 6d1d3e3 to ca93d40 Compare October 20, 2022 20:00
@mvllow
Copy link
Member

mvllow commented Oct 20, 2022

Thanks so much! Unable to test at the moment but will merge so people don't have a broken theme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants