Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change generators to IDL-based pipeline #24

Merged
merged 26 commits into from
Mar 12, 2019
Merged

change generators to IDL-based pipeline #24

merged 26 commits into from
Mar 12, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Nov 21, 2018 •
edited
Loading

Connected to ros2/rosidl#334.

@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@dirk-thomas dirk-thomas self-assigned this Nov 21, 2018
@dirk-thomas dirk-thomas mentioned this pull request Nov 22, 2018
Merged
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 26, 2018
@dirk-thomas dirk-thomas mentioned this pull request Feb 12, 2019
Closed
8 tasks
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019
@dirk-thomas dirk-thomas changed the title update includes and type mapping change generators to IDL-based pipeline Feb 19, 2019
@mikaelarguedas mikaelarguedas mentioned this pull request Feb 21, 2019
Closed
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
jacobperron
jacobperron reviewed Feb 22, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

FYI, as part of the review I've updated rclpy's ActionServer, which we can add to the idl-stage-7 branch once ros2/rclpy#270 is merged.

rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake Show resolved Hide resolved
rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake Show resolved Hide resolved
rosidl_generator_py/resource/_idl_pkg_typesupport_entry_point.c.em Show resolved Hide resolved
rosidl_generator_py/resource/_idl_pkg_typesupport_entry_point.c.em Show resolved Hide resolved
rosidl_generator_py/resource/_msg.py.em Show resolved Hide resolved
rosidl_generator_py/resource/_msg.py.em Show resolved Hide resolved
@dirk-thomas dirk-thomas merged commit abbb86e into master Mar 12, 2019
@dirk-thomas dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:11
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
This was referenced Mar 13, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @jacobperron @hidmic