Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change generator to IDL-based pipeline #47

Merged
merged 38 commits into from
Mar 12, 2019
Merged

change generator to IDL-based pipeline #47

merged 38 commits into from
Mar 12, 2019

Conversation

jacobperron
Copy link
Member

Moved from #46

Connects to ros2/rosidl#334

dirk-thomas and others added 24 commits November 29, 2018 13:59
@dirk-thomas
sketch of idl2idl templates
61e4a21
@jacobperron
invoke idl2idl template
bc21fda
@jacobperron
Update rosidl_generate_dds_interfaces to accept tuples of IDL files t…
7f6129e 
…o convert
@hidmic @jacobperron
Updates IDL templates for messages.
45f55cd
@jacobperron
Ok
5752b7b
@jacobperron
Fixes
18ae20f
@jacobperron
Allow context to be extended and add optional 'post-struct line gener…
dc3f83f 
…ation'
@jacobperron
Add trailing underscores to struct member names
69e3f79
@jacobperron
Add header guards
fdedd68
@jacobperron
Refactor idl.idl.em
b34e549
@hidmic
Propagates variables to nested templates.
bc79b13
@hidmic
Fixes bad indentation in templates.
57a5083
@hidmic
Propagates yet more variables.
83df6b7
@hidmic
Fixes installation paths for IDL files.
3351470
@hidmic
Moves header guards one template level up.
f7fc9df
@jacobperron
Add wrapper_msg.idl.em
dfa3a62
@hidmic
Fixes bad install macro call.
cfce7fc
@jacobperron
Rename variable for Service object to 'service'
aedbdea
@jacobperron
Add message templates for user-defined components of actions
5e7b2cd
@jacobperron
Pass in service wrapper templates rather than having them here
45ceffa
@hidmic
Always use slashes in IDL include paths.
ce8a45d
@jacobperron
Add missing check when converting negative int8 values to octet
4c0210d
@hidmic
Avoid duplicate include directives.
75dadd4
@jacobperron
Add underscore suffix to constants
a62a45f
@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 5, 2018
@dirk-thomas dirk-thomas mentioned this pull request Feb 12, 2019
Closed
8 tasks
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019
@dirk-thomas dirk-thomas changed the title Update generator to convert from IDL change generators to IDL-based pipeline Feb 19, 2019
@dirk-thomas dirk-thomas changed the title change generators to IDL-based pipeline change generator to IDL-based pipeline Feb 19, 2019
@dirk-thomas
Copy link
Member

@jacobperron Can you review this please? I can't select you as a reviewer though since you created the first version of the PR.

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
@jacobperron
Copy link
Member Author

jacobperron commented Feb 21, 2019 •
edited
Loading

@jacobperron Can you review this please? I can't select you as a reviewer though since you created the first version of the PR.

👍

jacobperron
jacobperron commented Feb 21, 2019
View reviewed changes
Copy link
Member Author

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I did contribute some of the changes (I think the parts I commented on were introduced by me 😆).

rosidl_generator_dds_idl/bin/rosidl_generator_dds_idl Outdated Show resolved Hide resolved
rosidl_generator_dds_idl/cmake/rosidl_generate_dds_interfaces.cmake Show resolved Hide resolved
rosidl_generator_dds_idl/bin/rosidl_generator_dds_idl Outdated Show resolved Hide resolved
jacobperron
jacobperron commented Feb 22, 2019
View reviewed changes
Copy link
Member Author

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am unable to approve my own PR.

dirk-thomas
dirk-thomas approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Representing the 👍 from @jacobperron.

@dirk-thomas dirk-thomas merged commit c80366c into master Mar 12, 2019
@dirk-thomas dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:12
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @dirk-thomas @hidmic