Add burst-mode to Player #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffrey Biggs <[email protected]>
gbiggs
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
MichaelOrlov
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
@gbiggs Thank you for clean implementation. It looks good to me.
Approved.
|
CI (
|
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API and a service to the Player object for burst-mode playback. Burst-mode playback will play the specified number of messages as fast as possible, ignoring the timing information stored in the bag for those messages. This is useful when, for example, you want to play a bag file into a processing pipeline that doesn't care about timing information and you want to process the data as fast as possible, rather than at the rate it was originally recorded.
A future extension of this API could change it to three methods,
burst_n_messages,burst_for_s_secondsandburst_up_to, which would burst a message count, all messages for a given time period, or all messages up to a timestamp, respectively.