-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colcon python warnings #3742
Conversation
….rst Co-authored-by: Yannick Goumaz <[email protected]>
…u.rst Co-authored-by: Yannick Goumaz <[email protected]>
…ws.rst Co-authored-by: Yannick Goumaz <[email protected]>
…tern Fix colcon python warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to add explanation something like this in the doc.
instead of adding this comments before every tutorial that issues colcon build
, how about adding it in the doc known issue
for humble
and iron
release note?
I agree it doesn't hurt to add this into the |
I have to say that I'm reluctant to put this into the official documentation, especially now that we have a solution on the horizon: https://discourse.ros.org/t/call-for-testing-standards-based-python-packaging-with-colcon/32008 |
I will be happy to remove it as soon as the solution is effective. All users bump into this problem and they react differently:
Do we really want this? |
I agree it isn't great, but as soon as we add this type of thing to the official documentation, people will copy it everywhere. And it has the side-effect of hiding these warnings for all Python packages, whether they are part of ROS or not. So I still think it is better to fix it at the source (as we are doing with |
I fully agree it is better to fix it at the source. But I fear this will take long and meanwhile users are getting confused. |
At the moment, I do not. But I hope it is soon. |
OK, so this problem will remain unresolved for an undefined amount of time... To me, this is a very bad approach and gives a poor impression on the quality of the ROS 2 software and its documentation. USE CASE: As a new robotics developer, I want to try out ROS 2.
In all the cases, the results is a very poor developer experience with the feeling that the quality of the ROS 2 software and/or documentation is low. I believe that fixing the official documentation would resolve the problem, even though I agree that it may have some side effects, like people creating video tutorials with these instructions that will become obsolete after the problem is patched. But this is generally the case for any outdated tutorial, so I am pretty sure we should not bother about this. And of course, we should fix the official documentation as soon as the patch reaches the official distributions. |
So, it turns out that https://discourse.ros.org/t/call-for-testing-standards-based-python-packaging-with-colcon/32008 isn't going to be ready for Jazzy. While that is still the correct way forward, for now we are going to suppress the warning within colcon: colcon/colcon-core#626. The benefit there is that it restricts the suppression to only things built with colcon, not the whole system . So with that said, I'm going to close this out. |
This PR adds instructions to disable the print of colcon python warnings on stderr that are confusing users.
It implements the recommended solution explained here.
We are aiming at merging this PR to rolling, humble and iron.