Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bridge command parser #399

Closed
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
041a53b
Refactor command parser to use vector of char*
LucasHaug Feb 3, 2023
82bdd30
Add argc argv splitter to dynamic bridge
LucasHaug Feb 3, 2023
5359817
Add argc argv splitter to paramter bridge
LucasHaug Feb 3, 2023
fd96bcf
Update github action
LucasHaug Feb 3, 2023
40dd1b2
Fix parameter bridge argv split
LucasHaug Feb 3, 2023
883d777
Remove static argv reading
LucasHaug Feb 3, 2023
ce8b178
Add command parser to parameter bridge
LucasHaug Feb 3, 2023
2911f8f
Fix compilation errors
LucasHaug Feb 3, 2023
8650d49
Fix compilation errors
LucasHaug Feb 6, 2023
f5f39a1
Fix parameter bidge command parser
LucasHaug Feb 6, 2023
b99c2a3
Refactor to add command parser utils file
LucasHaug Feb 6, 2023
2e47d5e
Add github action issue workaround
LucasHaug Feb 6, 2023
7bcbb2d
Ty to run github action inside container
LucasHaug Feb 6, 2023
7d32936
Fix ROS2 args when no ROS1 args
LucasHaug Feb 8, 2023
9a341f2
⏪ Revert changes on GitHub Action config
LucasHaug Mar 10, 2023
3b00615
Change parameter bridge ROS init order
LucasHaug Mar 10, 2023
38460e6
Rename parser functions
LucasHaug Mar 10, 2023
1097b4f
Add get_option_values function
LucasHaug Mar 10, 2023
02e1d27
Fix wrong help for the parameter bridge
LucasHaug Mar 10, 2023
5804cdc
Fix get_option_values parser function
LucasHaug Mar 10, 2023
d76cb81
Refactor bridges to use the get_option_values
LucasHaug Mar 10, 2023
daf83db
Add running scetion to README
LucasHaug Mar 10, 2023
d557b00
Add print pairs to parameter bridge
LucasHaug Mar 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
⏪ Revert changes on GitHub Action config
Signed-off-by: LucasHaug <[email protected]>
LucasHaug committed Mar 10, 2023
commit 9a341f22b7afd3f3bad2e5af36ea7f0380d184ac
14 changes: 9 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -4,11 +4,15 @@ on: [push, pull_request] # on all pushes and PRs

jobs:
ros1_bridge:
runs-on: ubuntu-20.04
container:
image: ros:rolling-ros1-bridge
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: ros-tooling/[email protected]
with:
required-ros-distributions: "noetic rolling"
- name: Build and test ros1-bridge
run: |
/ros_entrypoint.sh colcon build --allow-overriding ros1_bridge
uses: ros-tooling/[email protected]
with:
package-name: ros1_bridge
target-ros1-distro: noetic
target-ros2-distro: rolling