Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpplint error #341

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fix cpplint error #341

merged 2 commits into from
Jan 17, 2022

Conversation

Blast545
Copy link
Contributor

@Blast545
Fix cpplint error
e468ae6 
Signed-off-by: Jorge Perez <[email protected]>
clalancette
clalancette approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, assuming ci_packaging CI is green.

@Blast545
Copy link
Contributor Author

@clalancette I wanted to trigger a ci_linux job using the same parameters as the packaging_linux but the ci_linux one doesn't have the parameter CI_MIXED_ROS_OVERLAY_PKGS (where actually ros1_bridge is added).

What can I do to test this PR in this scenario?

@clalancette
Copy link
Contributor

What can I do to test this PR in this scenario?

You can trigger https://ci.ros2.org/job/ci_packaging_linux/ and https://ci.ros2.org/job/ci_packaging_linux-aarch64/

@Blast545
Copy link
Contributor Author

Blast545 commented Jan 14, 2022 •
edited
Loading

@clalancette Oh, I didn't know about that one. Thanks!

ci_packaging_linux up to rcutils with cycloneDDS only (the error does not come from the ros2 environment, so it's not needed to build the whole thing)
Build Status

ci_packaging_linux up to ros1_bridge with cycloneDDS only
Build Status

@Blast545
Fix linter, attempt 2
3538f0f 
Signed-off-by: Jorge Perez <[email protected]>
@Blast545
Copy link
Contributor Author

Blast545 commented Jan 14, 2022 •
edited
Loading

I tested 3538f0f with cpplint locally, it should pass the CI test.

ci_packaging_linux up to ros1_bridge with cycloneDDS only
Build Status

@Blast545
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@Blast545 Blast545 merged commit e9b044b into master Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the blast545/fix_cpplint_20220114 branch January 17, 2022 20:52
tompe17 pushed a commit to tompe17/ros1_bridge that referenced this pull request Mar 25, 2022
@Blast545
Fix cpplint error (ros2#341)
d5f3d99 
* Fix cpplint error

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tommy Persson <[email protected]>
tompe17 pushed a commit to tompe17/ros1_bridge that referenced this pull request Mar 25, 2022
@Blast545
Fix cpplint error (ros2#341)
c60ae09 
* Fix cpplint error

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tommy Persson <[email protected]>
tompe17 pushed a commit to tompe17/ros1_bridge that referenced this pull request Mar 25, 2022
@Blast545
Fix cpplint error (ros2#341)
318ccfe 
* Fix cpplint error

Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Tommy Persson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blast545 @clalancette @fujitatomoya