Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rcpputils/scope_exit.hpp instead of rclcpp/scope_exit.hpp #324

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Use rcpputils/scope_exit.hpp instead of rclcpp/scope_exit.hpp #324

merged 1 commit into from
Aug 31, 2021

Conversation

christophebedard
Copy link
Member

See ros2/rclcpp#1727 (comment)

Signed-off-by: Christophe Bedard [email protected]

clalancette
clalancette approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me with green CI.

@christophebedard
Copy link
Member Author

I'm guessing GitHub CI is enough? Since ros1_bridge is seemingly always ignored by ci.ros2.org

@clalancette
Copy link
Contributor

I'm guessing GitHub CI is enough? Since ros1_bridge is seemingly always ignored by ci.ros2.org

You should be able to run the ci_packaging job, which builds the bridge.

@christophebedard
Copy link
Member Author

You should be able to run the ci_packaging job, which builds the bridge.

ah I see!

  • Linux packaging Build Status

@christophebedard christophebedard mentioned this pull request Aug 31, 2021
Closed
@clalancette clalancette merged commit 4c89542 into ros2:master Aug 31, 2021
@christophebedard christophebedard deleted the replace-scope-exit-header branch August 31, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophebedard @clalancette