Disable rosout logging for Fast-RTPS tests #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
|
While this patch fixes the test it doesn't address the same problem for users running the bridge, right? |
|
Correct. Are you thinking of forcing the configuration behind the scenes? |
|
Yes, the bridge node would always apply that flag - even if not specified on the command line. As least that is the only way I see this would work for users... |
|
Superseded by #197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ros2/build_farmer#192 (again). Incidentally, I came across some typos in the CMakeLists.txt affecting the tests (!) that got past review/CI before. Those are fixed in their own separate commit.