Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very minor typo in comments #297

Merged
merged 2 commits into from
Dec 22, 2020
Merged

very minor typo in comments #297

merged 2 commits into from
Dec 22, 2020

Conversation

Vicidel
Copy link
Contributor

@Vicidel Vicidel commented Nov 23, 2020

as the documentation for parameter bridge is lacking, better to have comments without typo to avoid time waste on the user side

src/parameter_bridge.cpp Outdated Show resolved Hide resolved
src/parameter_bridge.cpp Outdated Show resolved Hide resolved
Co-authored-by: tomoya <[email protected]>
Signed-off-by: Steven! Ragnarök <[email protected]>
@nuclearsandwich
Copy link
Member

@Vicidel these changes are probably small enough not to need a DCO but if you add one it will make the bot happy and we don't have to think about it.

@Vicidel
Copy link
Contributor Author

Vicidel commented Nov 24, 2020

The DCO guide there doesn't work for me with error :

$ git push --force-with-lease origin patch-1
ERROR: Permission to ros2/ros1_bridge.git denied to Vicidel.
fatal: Could not read from remote repository.

I'll try to solve this for the future.

@nuclearsandwich
Copy link
Member

The DCO guide there doesn't work for me with error :

I expect it is failing because I've applied the suggestions as a further commit on top of your changes. If you do a git pull --rebase origin patch-1 before trying again I think that should do it.

@sloretz
Copy link
Contributor

sloretz commented Dec 1, 2020

@Vicidel friendly ping :) Thanks for the PR! Mind trying the fix @nuclearsandwich suggested?

@Vicidel
Copy link
Contributor Author

Vicidel commented Dec 2, 2020

Sorry for the delay, I tested it but I still have errors:

$ git pull --rebase origin patch-1
fatal: Couldn't find remote ref patch-1
$ git push --force-with-lease origin patch-1
remote: Permission to ros2/ros1_bridge.git denied to Vicidel.
fatal: unable to access 'https://github.com/ros2/ros1_bridge.git/': The requested URL returned error: 403

@clalancette clalancette added the more-information-needed Further information is required label Dec 18, 2020
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is a small change to a comment, I'll just manually bypass the DCO bot in order to resolve this ticket.

@jacobperron jacobperron merged commit b520c5f into ros2:master Dec 22, 2020
@Vicidel Vicidel deleted the patch-1 branch January 4, 2021 09:03
@Vicidel
Copy link
Contributor Author

Vicidel commented Jan 4, 2021

Sorry about this, I'm not used to open source and these kind of things. I will be careful in the future to comply to DCO.
Thank you for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants