-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
very minor typo in comments #297
Conversation
Co-authored-by: tomoya <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
5b03b85
to
7cf38e5
Compare
@Vicidel these changes are probably small enough not to need a DCO but if you add one it will make the bot happy and we don't have to think about it. |
The DCO guide there doesn't work for me with error :
I'll try to solve this for the future. |
I expect it is failing because I've applied the suggestions as a further commit on top of your changes. If you do a |
@Vicidel friendly ping :) Thanks for the PR! Mind trying the fix @nuclearsandwich suggested? |
Sorry for the delay, I tested it but I still have errors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering this is a small change to a comment, I'll just manually bypass the DCO bot in order to resolve this ticket.
Sorry about this, I'm not used to open source and these kind of things. I will be careful in the future to comply to DCO. |
as the documentation for parameter bridge is lacking, better to have comments without typo to avoid time waste on the user side