Clear the error after rmw_serialized_message_resize() #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one. Signed-off-by: Chris Lalancette <[email protected]>
ahcorde
approved these changes
Jan 24, 2025
|
https://github.com/Mergifyio backport jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e638f8c)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e638f8c)
ahcorde
pushed a commit
that referenced
this pull request
Jan 24, 2025
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e638f8c) Co-authored-by: Chris Lalancette <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jan 24, 2025
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e638f8c) Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is actually an alias for rcutils_uint8_array_resize(), so the error message isn't useful. Instead, reset the error and set a more useful one.