Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected #427

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected #427

merged 2 commits into from
Jan 17, 2025

Conversation

JEnoch
Copy link
Contributor

@JEnoch JEnoch commented Jan 17, 2025

Fix #426

  1. The call to std::vector<Id> Session::get_routers_z_id(ZResult*) was checking the ZResult, but not the size of the returned vector.
  2. in Don't block in rmw_init checking for the router. #308 the default value of ZENOH_ROUTER_CHECK_ATTEMPTS was changed from 0 to 1. This PR updates the README to reflect this change, and clarify the behaviour after the checks complete.

Yadunund
Yadunund approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Yadunund Yadunund merged commit 6f910bf into ros2:rolling Jan 17, 2025
5 checks passed
@Yadunund
Copy link
Member

@Mergifyio backport jazzy humble

@mergify Mergify
Copy link

mergify bot commented Jan 17, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@JEnoch @mergify
Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (#427)
589993a 
* Fix check of connection to a router

* README: update ZENOH_ROUTER_CHECK_ATTEMPTS following default value change in #308

(cherry picked from commit 6f910bf)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@JEnoch @mergify
Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (#427)
fbd4af5 
* Fix check of connection to a router

* README: update ZENOH_ROUTER_CHECK_ATTEMPTS following default value change in #308

(cherry picked from commit 6f910bf)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
Yadunund pushed a commit that referenced this pull request Jan 17, 2025
@mergify @JEnoch
Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (#427) (#428)
8bbca81 
* Fix check of connection to a router

* README: update ZENOH_ROUTER_CHECK_ATTEMPTS following default value change in #308

(cherry picked from commit 6f910bf)

Co-authored-by: Julien Enoch <[email protected]>
Yadunund pushed a commit that referenced this pull request Jan 17, 2025
@mergify @JEnoch
Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (#427) (#429)
1f57c46 
* Fix check of connection to a router

* README: update ZENOH_ROUTER_CHECK_ATTEMPTS following default value change in #308

(cherry picked from commit 6f910bf)

Co-authored-by: Julien Enoch <[email protected]>
@JEnoch JEnoch deleted the fix/426 branch January 17, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZENOH_ROUTER_CHECK_ATTEMPTS is not respected
2 participants
@JEnoch @Yadunund