Crystal backports #268
Merged
Crystal backports #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
approved these changes
Mar 26, 2019
|
Overriding the DCO check since fc4b27e came in before we started enforcing the DCO on this repository. So I'll merge this. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports commits ea4fb7c and fc4b27e (PRs #256 and #264, respectively) into Crystal. These are needed as part of the fixes to bring Fast-RTPS up to version 1.7.2. Note that these have to go in before the update to v1.7.2, otherwise this will fail to build. A full CI run for these changes was run as part of ros2/ros2#669 (comment) . @nuclearsandwich FYI