Use rosidl_get_typesupport_target and target_link_libraries #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
|
@hidmic I've added you as a reviewer, but this one seems to depend on ros2/rosidl_typesupport#123 which depends on ros2/rosidl#662, so I've left it as a draft for now. |
cottsay
approved these changes
Mar 23, 2022
|
CI (build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is currently hard-coding the include directories for the generator packages it depends on. This makes it use
rosidl_get_typesupport_target()insteadl. I also made it usetarget_link_librariesinstead ofament_target_dependencies.I think this depends on ros2/rosidl_typesupport#123, but I don't remember why (Edit: I think it needs that cleanup PR to get the dependency on rosidl_generator_c transitively from rosidl_generator_cpp instead of hard coding both)