This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Added basic qos for readers and writers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux buildfarm: http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_linux/155/ |
|
Linux buildfarm: http://54.183.26.131:8080/view/ros2/job/ros2_batch_ci_linux/156/ |
| datawriter_qos.reliability.kind = DDS_RELIABLE_RELIABILITY_QOS; | ||
| break; | ||
| default: | ||
| throw std::runtime_error("Unknown QoS policy"); |
There was a problem hiding this comment.
It would be good if the error string would include the actual numeric value of qos_policy.
Same below.
esteve
force-pushed
the
qos
branch
2 times, most recently
from
6a7804c to
6b56566
Compare
esteve
force-pushed
the
qos
branch
3 times, most recently
from
5bc3e2c to
f547eee
Compare
esteve
added
in review
esteve
force-pushed
the
qos
branch
2 times, most recently
from
58ca455 to
49278e0
Compare
esteve
force-pushed
the
qos
branch
3 times, most recently
from
f88a880 to
7fa696b
Compare
| @@ -367,19 +367,46 @@ rmw_create_publisher( | |||
| goto fail; | |||
| } | |||
|
|
|||
| datawriter_qos.reliability.max_blocking_time.sec = 2; | |||
| datawriter_qos.reliability.max_blocking_time.nanosec = 0; | |||
There was a problem hiding this comment.
Should we set these limits generically?
|
lgtm |
|
+1 |
esteve
force-pushed
the
qos
branch
2 times, most recently
from
50b39e3 to
6797f1e
Compare
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#66