-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: get clients, servers info #371
base: rolling
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in rmw service endpoints are handled as topics internally, precisely client is DataReader
and server is DataWriter
to fill in the topic endpoint information. so all the field of rmw_topic_endpoint_info_t
can be filled in with calling the graph cache.
IMO i think in rmw we can use rmw_topic_endpoint_info_t
as it is now, but i would add comment that says this structure is used for service client and server as well.
@wjwwood Mind taking a look at this new rmw API 🧇 ? |
@leeminju531 , any updates from your end? |
Signed-off-by: Minju, Lee <[email protected]>
Signed-off-by: Minju, Lee <[email protected]>
2c52767
to
3ac5f99
Compare
@methylDragon @fujitatomoya, Updated with underlying implementations first:). |
@leeminju531 thanks for putting the effort on this. i will do the another review once they are ready, so please let me know. |
Add get clients, servers info
Refer to ros2/ros2cli#916