-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes ros_timer_init for ros_timer_init2 #999
Conversation
Signed-off-by: Voldivh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not change user experience with autostart
flag for rclpy, i would recommend that rclpy as the same option as a counterpart of ros2/rclcpp#2005
Pulls: ros2/rcl#1004, ros2/rclcpp#2005, ros2/system_tests#508, #999 |
CI is green, see ros2/rcl#1004 (comment) |
you are not gonna implement this at this time? maybe this would be follow-up task for |
Taking into account the chain of PR's given this one ros2/rcl#1004 . Would it be ok if we address this comment in a different PR? |
This PR is a follow up of rcl#1004 and should be merged after that PR is merged.
Signed-off-by: Voldivh [email protected]