Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashing] Fix get_node_interfaces functions taking a pointer (#821) #870

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[Dashing] Fix get_node_interfaces functions taking a pointer (#821) #870

merged 1 commit into from
Sep 26, 2019
+35 −9

Conversation

ivanpauno
Copy link
Member

Backports #821

@ivanpauno ivanpauno requested a review from hidmic September 24, 2019 19:26
@ivanpauno ivanpauno self-assigned this Sep 24, 2019
@ivanpauno ivanpauno changed the title Fix get_node_interfaces functions taking a pointer (#821) [Dashing] Fix get_node_interfaces functions taking a pointer (#821) Sep 24, 2019
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Sep 24, 2019
@ivanpauno ivanpauno requested a review from wjwwood September 25, 2019 18:52
wjwwood
wjwwood approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't think it should cause a regression, especially with CI checking that everything we build compiles.

@ivanpauno
Copy link
Member Author

ivanpauno commented Sep 25, 2019 •
edited
Loading

CI, build everything, test rclcpp test_rclcpp, dashing repos:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit f954ce5 into dashing Sep 26, 2019
@clalancette clalancette deleted the ivanpauno/backport-#821 branch October 14, 2019 17:14
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
@WJaworskiRobotec
Metadata per file info (ros2#870)
4615fba 
* added per-file info to metadata.yaml

Signed-off-by: Wojciech Jaworski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @wjwwood