[foxy backport] Backport various unit tests for coverage #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahcorde
approved these changes
Oct 9, 2020
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part7
branch
from
6433853
to
d6f1f34
Compare
* Add file to test graph_listener * Add tests start graph listener * Add tests errors run graph listener * Add tests add/remove node * Remove dynamic cast * Remove repeated line * Remove comment * Add reset to avoid warning * Add checks construction graph listener * Add tests shutdown * Change node_graph definition * Remove test failing MacOS * Remove test not working on Windows Signed-off-by: Jorge Perez <[email protected]>
This gets this file up to 97% coverage. Signed-off-by: Chris Lalancette <[email protected]>
* Add tests for node_options API Signed-off-by: Stephen Brawner <[email protected]> * Remove c-style casts Signed-off-by: Stephen Brawner <[email protected]>
This gets us to 100% line coverage. Signed-off-by: Chris Lalancette <[email protected]>
* Add in more tests for the utilities. Signed-off-by: Chris Lalancette <[email protected]>
* Complete coverage of Parameter and ParameterValue API Signed-off-by: Stephen Brawner <[email protected]> * Adding comments Signed-off-by: Stephen Brawner <[email protected]>
* Test the remaining node public API Signed-off-by: Stephen Brawner <[email protected]> * Address PR feedback Signed-off-by: Stephen Brawner <[email protected]> * Add comment Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part8
branch
from
c7cde75
to
a3dd124
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part7
to
brawner/rclcpp-backport-tests-part1
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports more PRs for coverage in foxy. This PR will be rebase and merged onto #1383 before final rebase and merging onto foxy.
A couple of the commits were slightly modified to remove tests for API that does not exist in foxy ( primarily a513dc6, c7cde75)
Coverage PRs: #1330, #1346, #1343, #1350, #1349, #1344, #1342, #1353