-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose --params-file option to composable nodes #1215
Comments
dawonn-haval
added a commit
to dawonn-haval/rclcpp
that referenced
this issue
Jul 9, 2020
dawonn-haval
added a commit
to dawonn-haval/rclcpp
that referenced
this issue
Jul 9, 2020
dawonn-haval
added a commit
to dawonn-haval/rclcpp
that referenced
this issue
Jul 9, 2020
Fixes ros2#1215 Signed-off-by: Dereck Wonnacott <[email protected]>
dawonn-haval
added a commit
to dawonn-haval/rclcpp
that referenced
this issue
Jul 9, 2020
Fixes ros2#1215 Signed-off-by: Dereck Wonnacott <[email protected]>
Closing in favor of ros2/launch_ros#156. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Moving from ros2/launch_ros#156
Upgrading from Dashing to Foxy broke my parameter.yaml files that I was using in a composable node. After some debugging I found out that the composable node manager has it's own method for loading parameters from a yaml file that is different from rclcpp's parameter yaml file loader that was used in Dashing. The 'new' file format does not support defining parameters for multiple nodes so I would like to expose the --params-file flag in the component manager service so that the prior logic can be used.
Required Info:
Steps to reproduce issue
See ros2/launch_ros#156
Expected behavior
I should be able to use the params file from dashing with multiple nodes in one file.
Actual behavior
the file format has changed and only a single node per file is possible with the new format.
Additional information
Pull request incoming shortly.
The text was updated successfully, but these errors were encountered: