[Foxy] Allow configuring logging directory through environment variables #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tgreier <[email protected]>
Signed-off-by: tgreier <[email protected]>
tgreier
force-pushed
the
log-dir-from-env-var
branch
from
032f623 to
ed60fd3
Compare
Signed-off-by: tgreier <[email protected]>
tgreier
force-pushed
the
log-dir-from-env-var
branch
from
4049be7 to
ed278ba
Compare
|
@ivanpauno Hello, could you please review this PR? |
ivanpauno
approved these changes
Jan 7, 2021
jacobperron
approved these changes
Jan 7, 2021
|
Testing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of functionality from PR Allow configuring logging directory through environment variables #53.
This allows configuring the logging directory through environment variables using the following logic:
Use $ROS_LOG_DIR if ROS_LOG_DIR is set and not empty.
Otherwise, use $ROS_HOME/log, using ~/.ros for ROS_HOME if not set or if empty.
Implemented only for spd log.
Should it also be added for log4cxx? If so, should a copy of the rcl_logging_get_logging_directory API be added to the log4cxx package?