Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated CLI rules on F-Turtle #500

Closed
hidmic opened this issue Sep 13, 2019 · 0 comments · Fixed by #603
Closed

Remove deprecated CLI rules on F-Turtle #500

hidmic opened this issue Sep 13, 2019 · 0 comments · Fixed by #603
Assignees
Labels
enhancement New feature or request

Comments

@hidmic
Copy link
Contributor

hidmic commented Sep 13, 2019

Feature request

Feature description

As of #496, ROS specific CLI arguments have changed and what used to be valid syntax as of Dashing is now formally deprecated.

#define RCL_ROS_ARGS_FLAG "--ros-args"
#define RCL_ROS_ARGS_EXPLICIT_END_TOKEN "--"
#define RCL_PARAM_FLAG "--param"
#define RCL_SHORT_PARAM_FLAG "-p"
#define RCL_PARAM_FILE_FLAG "--params-file"
#define RCL_REMAP_FLAG "--remap"
#define RCL_SHORT_REMAP_FLAG "-r"
#define RCL_LOG_LEVEL_FLAG "--log-level"
#define RCL_EXTERNAL_LOG_CONFIG_FLAG "--log-config-file"
// To be prefixed with --enable- or --disable-
#define RCL_LOG_STDOUT_FLAG_SUFFIX "stdout-logs"
#define RCL_LOG_ROSOUT_FLAG_SUFFIX "rosout-logs"
#define RCL_LOG_EXT_LIB_FLAG_SUFFIX "external-lib-logs"
// \deprecated to be removed in F-Turtle
#define RCL_LOG_LEVEL_ARG_RULE "__log_level:="
#define RCL_EXTERNAL_LOG_CONFIG_ARG_RULE "__log_config_file:="
#define RCL_LOG_DISABLE_STDOUT_ARG_RULE "__log_disable_stdout:="
#define RCL_LOG_DISABLE_ROSOUT_ARG_RULE "__log_disable_rosout:="
#define RCL_LOG_DISABLE_EXT_LIB_ARG_RULE "__log_disable_external_lib:="
#define RCL_PARAM_FILE_ARG_RULE "__params:="

This will remain true for Eloquent. Starting with F-Turtle, the old syntax must be removed.

@mabelzhang mabelzhang added the enhancement New feature or request label Sep 26, 2019
@jacobperron jacobperron self-assigned this Mar 20, 2020
jacobperron added a commit that referenced this issue Mar 20, 2020
Resolves #500

Signed-off-by: Jacob Perron <[email protected]>
jacobperron added a commit that referenced this issue Apr 7, 2020
Resolves #500

Signed-off-by: Jacob Perron <[email protected]>
jacobperron added a commit that referenced this issue Apr 10, 2020
* Remove deprecated CLI rules

Resolves #500

Signed-off-by: Jacob Perron <[email protected]>

* Remove tests for deprecated CLI arguments

Signed-off-by: Jacob Perron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants