Backport feature Prism in SolidPrimitive.msg to Galactic #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
force-pushed
the
backport-galactic-solid-primitive-prism
branch
from
3db0603 to
55bcd99
Compare
|
Similarly, we cannot backport this to Galactic as this would break API/ABI. So I'll close this out. |
|
@clalancette you might also want to add the API/ABI check to the CI in galactic as well. It has triggered the CI in foxy but not in galactic. |
|
Good call, see ros/rosdistro#31428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #166
With #167 is merged to master, I would like to backport this small feature to galactic.
Since this only adds a new field and type, it should maintain backwards compatibilty.