Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No robot model when using display.launch (again) #6

Closed
gavanderhoorn opened this issue Dec 29, 2013 · 1 comment
Closed

No robot model when using display.launch (again) #6

gavanderhoorn opened this issue Dec 29, 2013 · 1 comment

Comments

@gavanderhoorn
Copy link
Contributor

Similar to #4. Seems the commits merged in PR #5 did not take the install location specified in the CMakeLists.txt into account.

AFAIU the current layout of the package will make it work either in the source / devel workspace, or the install workspace (due to present / missing urdf_tutorial/ subdir). I can change the launch files or the CMakeLists.txt, but don't know what the preferred situation is.
@isucan
Copy link
Contributor

isucan commented Dec 31, 2013

We should use a layout for the launch files that is the same in the install and the devel locations, so things work in both cases. It sounds like to me we may need to move files around and update the CMakeLists.txt as well?

@shaun-edwards shaun-edwards mentioned this issue Jan 7, 2014
Closed
@isucan isucan closed this as completed in 15d5a08 Jan 9, 2014
isucan added a commit that referenced this issue Jan 9, 2014
@isucan
Merge pull request #7 from gavanderhoorn/issue6_source_vs_devel_vs_in…
766363b 
…stall

Fix issue #6: No robot model when using display.launch (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isucan @gavanderhoorn