Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2_kortex: 0.2.3-4 in 'humble/distribution.yaml' [bloom] #44217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aalmrad
Copy link

@aalmrad aalmrad commented Jan 17, 2025

Increasing version of package(s) in repository ros2_kortex to 0.2.3-4:

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Jan 17, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

- kortex_api
- kortex_bringup
- kortex_description
- kortex_driver
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros2-gbp/ros2_kortex-release.git
version: 0.2.2-1
url: https://github.com/aalmrad/ros2_kortex-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need write access to the ros2-gbp release repo?

@felixmaisonneuve & @moriarty I see you've done releases of ros2_kortex in the past. Should @aalmrad be added to the release team for ros2_kortex?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloretz Thank you for raising this point.

After @felixmaisonneuve and @moriarty left Kinova, I’ve taken over responsibilities for maintaining and releasing the ros2_kortex package and write access would be helpful moving forward.

Thank you for your support!

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloretz sloretz added the changes requested Maintainers have asked for changes to the pull request label Jan 17, 2025
@sloretz
Copy link
Contributor

sloretz commented Jan 17, 2025

Holding for Humble sync

@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jan 17, 2025
@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Jan 21, 2025
@sloretz sloretz self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants