Fixed gz_ros2_control keys: Iron and Rolling #37773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
github-actions
bot
added
iron
mjcarroll
added
the
held for sync
|
Iron is held for sync https://discourse.ros.org/t/preparing-for-iron-sync-2023-06-30/32099 |
clalancette
requested changes
Jul 5, 2023
Comment on lines
+1745
to
+1746
| url: https://github.com/ros2-gbp/ign_ros2_control-release.git | ||
| version: 1.1.0-1 |
There was a problem hiding this comment.
Something is weird here; this version does not exist in https://github.com/ros2-gbp/ign_ros2_control-release , and that is why CI is failing.
clalancette
added
changes requested
sloretz
reviewed
Jul 12, 2023
| - gz_ros2_control_demos | ||
| tags: | ||
| release: release/iron/{package}/{version} | ||
| url: https://github.com/ros2-gbp/ign_ros2_control-release.git |
There was a problem hiding this comment.
@ahcorde is this the right release repo? I notice it still has "ign" in the name. Not a problem, but @clalancette noticed the version listed here doesn't exist in this release repo.
|
@clalancette and @sloretz I will try a different approach, I will remove the key |
|
I'm going to close this one and assume that you'll redo the iron release in the same way as rolling above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due the renaming from ign to gz this package should use a different key, package names have changed too.