Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to libpcl keys #31561

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Updates to libpcl keys #31561

merged 3 commits into from
Jan 6, 2022

Conversation

nuclearsandwich
Copy link
Member

  • libpcl-all
    • Add definitions for Debian Bullseye.
    • Add definitions for Ubuntu Jammy.
    • Drop definitions for out-of-support Debian distributions.
    • Drop definitions for out-of-support Ubuntu distributions.
  • libpcl-all-dev
    • Remove out-of-support Ubuntu distributions and consolidate Ubuntu key.

@nuclearsandwich nuclearsandwich added the rosdep Issue/PR is for a rosdep key label Dec 23, 2021
@nuclearsandwich nuclearsandwich self-assigned this Dec 23, 2021
@nuclearsandwich nuclearsandwich requested a review from a team as a code owner December 23, 2021 04:24
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to libpcl-all-dev seem fine; all remotely recent Ubuntu releases use that name.

I suspect the changes to libpcl-all are more controversial. In particular, the removal of the xenial and the stretch keys may run in to the same objections that we've seen elsewhere. So I'll suggest we add those back in.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re xenial: We talked about it in #31569 and have guidance for how to use older tags. I'd suggest that we go ahead and remove them.

@nuclearsandwich
Copy link
Member Author

In particular, the removal of the xenial and the stretch keys may run in to the same objections that we've seen elsewhere. So I'll suggest we add those back in.

Re xenial: We talked about it in #31569 and have guidance for how to use older tags. I'd suggest that we go ahead and remove them.

I've added f8f8314 which redefines the key for xenial and once that issue is closed I'll sweep through and remove the xenial entries that I maintained. I am not doing the same for Stretch because no one has come out of the woodwork for it.

* Remove out-of-support Ubuntu distributions and consolidate Ubuntu key.
* Add definitions for Debian Bullseye.
* Add definitions for Ubuntu Jammy.
* Drop definitions for out-of-support Debian distributions.
* Drop definitions for out-of-support Ubuntu distributions.
@nuclearsandwich nuclearsandwich merged commit 4b95b0c into master Jan 6, 2022
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/pcl branch January 6, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants