Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librealsense: 2.34.0-1 in 'dashing/distribution.yaml' [bloom] #24521

Merged
merged 1 commit into from
May 14, 2020

Conversation

sharronliu
Copy link
Contributor

Increasing version of package(s) in repository librealsense to 2.34.0-1:

@nuclearsandwich nuclearsandwich merged commit 9b1a85d into ros:master May 14, 2020
@nuclearsandwich
Copy link
Member

@sharronliu this release is not building on Dashing.

See the latest builds here:

Here's an excerpt from the log which looks suspicious: http://build.ros2.org/view/Dbin_uB64/job/Dbin_uB64__librealsense2__ubuntu_bionic_amd64__binary

23:02:57 CMake Error: install(EXPORT "realsense2Targets" ...) includes target "realsense2" more than once in the export set.
23:02:57 CMake Error: install(EXPORT "realsense2Targets" ...) includes target "realsense2" more than once in the export set.
23:02:57 CMake Error: install(EXPORT "realsense2-glTargets" ...) includes target "realsense2-gl" which requires target "realsense2" that is not in this export set, but 2 times in others.

Do you think we should revert to the previous release until this error can be addressed?

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-dashing-sync-and-patch-release-2020-07-14/15287/4

nuclearsandwich added a commit that referenced this pull request Jul 16, 2020
Reverts #24521

This release has not built on Dashing but previous releases have.
Since the maintainers currently have other priorities[[1]] reverting to a
working release is the best course of action available.

[1]: IntelRealSense/librealsense#5825 (comment)
nuclearsandwich added a commit that referenced this pull request Jul 16, 2020
#25837)

Reverts #24521

This release has not built on Dashing but previous releases have.
Since the maintainers currently have other priorities[[1]] reverting to a
working release is the best course of action available.

[1]: IntelRealSense/librealsense#5825 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants