-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOL Release platforms Debian Jessie, Fedora 23 and 24 #18151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Since it's been close to a week and there's been no known issues I will merge this. |
@tfoote Some jobs seem to not be disabled yet on build.ros.org - I noticed e.g. the PR job for Debian Jessie. |
This change breaks rosdep for jessie:
Not sure if this was intended. |
It's not directly intended but is actually basically correct. Since the rosdistro hasn't diverged much right now it would mostly keep working. However in general it should not be expected to keep working. New packages would incorrectly resolve etc. We likely should take a snapshot of the current state of the repository and export that as a jessie specific rosdep rules file that users can add to their rosdep sources. |
To keep the maintenance easy: perhaps just a |
I just stumbled upon this because rosdep still works for hydro on 12.04. Users might be confused that |
Yes, saving the file output by rosdep-generator is basically what we're looking for: https://github.com/mikepurvis/rosdep-generator It would just be a file we could store in github somewhere conveniently nearby the default rosdep rules. Maybe in an eol_distros folder. |
This is a follow on to ros-infrastructure/ros_buildfarm_config#118
Holding until we've confirmed jessie is shutdown cleanly.