Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL Release platforms Debian Jessie, Fedora 23 and 24 #18151

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Jun 7, 2018

This is a follow on to ros-infrastructure/ros_buildfarm_config#118

Holding until we've confirmed jessie is shutdown cleanly.

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tfoote
Copy link
Member Author

tfoote commented Jun 13, 2018

Since it's been close to a week and there's been no known issues I will merge this.

@tfoote tfoote merged commit b45aaa5 into master Jun 13, 2018
@tfoote tfoote deleted the tfoote-eol-jessie branch June 13, 2018 22:38
@dirk-thomas
Copy link
Member

@tfoote Some jobs seem to not be disabled yet on build.ros.org - I noticed e.g. the PR job for Debian Jessie.

@mathias-luedtke
Copy link
Contributor

This change breaks rosdep for jessie:

$ rosdep resolve catkin

ERROR: No definition of [catkin] for OS [debian]

No definition of [catkin] for OS [debian]
        rosdep key : catkin
        OS name    : debian
        OS version : jessie
        Data: _is_ros: true
osx:
  homebrew:
    packages:
    - ros/kinetic/catkin
ubuntu:
  xenial:
    apt:
      packages:
      - ros-kinetic-catkin

Not sure if this was intended.

@tfoote
Copy link
Member Author

tfoote commented Jun 19, 2018

It's not directly intended but is actually basically correct. Since the rosdistro hasn't diverged much right now it would mostly keep working. However in general it should not be expected to keep working. New packages would incorrectly resolve etc. We likely should take a snapshot of the current state of the repository and export that as a jessie specific rosdep rules file that users can add to their rosdep sources.

@mathias-luedtke
Copy link
Contributor

We likely should take a snapshot of the current state of the repository and export that as a jessie specific rosdep rules file that users can add to their rosdep sources.

To keep the maintenance easy: perhaps just a jessie_eol tag and a sources list that references these EOL distros with a higher priority?
(Haven't had a look yet at how rosdep handles this internally..)

@mathias-luedtke
Copy link
Contributor

I just stumbled upon this because rosdep still works for hydro on 12.04. Users might be confused that rosdep update breaks their set-up on jessie.

@tfoote
Copy link
Member Author

tfoote commented Jun 19, 2018

Yes, saving the file output by rosdep-generator is basically what we're looking for: https://github.com/mikepurvis/rosdep-generator It would just be a file we could store in github somewhere conveniently nearby the default rosdep rules. Maybe in an eol_distros folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants