Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add melodic. #16687

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Add melodic. #16687

merged 3 commits into from
Jan 5, 2018

Conversation

clalancette
Copy link
Contributor

add melodic distribution file + add melodic to index

Signed-off-by: Chris Lalancette [email protected]

@clalancette
Add melodic.
81ac474 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette mentioned this pull request Jan 4, 2018
Closed
88 tasks
@clalancette
Copy link
Contributor Author

Travis fails because the tests are looking for melodic in the index.yaml, which is added by this PR :).

@dirk-thomas
Copy link
Member

This should be ok to be merged. It should also be easy to update the catch this corner case make it pass.

@dirk-thomas
Copy link
Member

Please only put the line which can actually raise in the try / catch block.

@clalancette
Fixes from review.
f0f5ee1 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

Thanks! Merging.

@clalancette clalancette merged commit 61e903d into master Jan 5, 2018
@clalancette clalancette deleted the melodic branch January 5, 2018 15:50
@sloretz sloretz mentioned this pull request Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @dirk-thomas