-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue occuring during alternating calls of getParamCached and setParam #1439
Fixed issue occuring during alternating calls of getParamCached and setParam #1439
Conversation
To get this clear. The race, which this PR fixes, is this:
The example chosen in fff8901 might be contrived, but it is a simple way to reproduce this issue. |
Ok, as far as i can tell, the test for the rosmaster fails now, because the tests expects But test_rosmaster_paramserver.py tests I find this rather confusing. Also I do not see any purpose of this rather than making the test easier. |
…ller_id_to_ignore is not None
Maybe there should be new tests for |
@ros-pull-request-builder retest this please |
Well, two changes, which are pretty unrelated to the original purpose of this PR, fixed the builds now. |
@dirk-thomas As far as I am concerned this can be merged now. |
Thanks for the patch. |
…etParam (ros#1439) * test_roscpp/params/added getParamCachedSetParamLoop * rosmaster: set_param: the not update the caller! * rosmaster: set_param: do not update the caller more fine grained * /rosmaster/paramserver/compute_params_update, apply filter only if caller_id_to_ignore is not None * /test_rospy/talker: set publishers queue_size to supress warning * /test_rospy/sub_to_multple_pubs: moved listener up to avoid warnings * refactor for readability * pep8
…etParam (#1439) * test_roscpp/params/added getParamCachedSetParamLoop * rosmaster: set_param: the not update the caller! * rosmaster: set_param: do not update the caller more fine grained * /rosmaster/paramserver/compute_params_update, apply filter only if caller_id_to_ignore is not None * /test_rospy/talker: set publishers queue_size to supress warning * /test_rospy/sub_to_multple_pubs: moved listener up to avoid warnings * refactor for readability * pep8
fff8901 shows an issue which is likely a race condition in the interaction of the nodes parameter cache and the parameter server.