Make diagnostic aggregator composable #435
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya.
This PR makes the
diagnostic_aggregator
node composable (see #321 )Summary of changes:
Aggregator
class inherit fromrclcpp::Node
. Removing thestd::shared_ptr<Node>
member variable.Analyzer
base class to accept aNode&
instead of thestd::shared_ptr
rclcpp_component
AnalyzerGroup
plugin as existing the analyzers library. When composing the nodes I found thatAnalyzerGroup
would not load. I assume it has worked up to this point because everything was linked into the same executable.