CFG_EXTRAS doesnt support directories

[asmodehn]

using:

catkin_package(
  CFG_EXTRAS
  directory/file.cmake
)

and using:

catkin_package(
  CFG_EXTRAS
  file.cmake
)

will both finally install the file.cmake in the same location.

The directory should not be removed from the path...

I had the issue with this version : pyros-dev/catkin_pip@78eaaae

[asmodehn]

This leads to package requiring these extra to not find them. In my case :

CMake Error at /opt/ros/indigo/share/catkin_pip/cmake/catkin_pipConfig.cmake:190 (include):

  include could not find load file:

    /opt/ros/indigo/share/catkin_pip/cmake/test/pytest.cmake

[dirk-thomas]

While keeping a relative path would be possible the passed filename can also be absolute and then it would be more difficult to still ensure that multiple files don't collide. Therefore catkin simplifies the process and uses just the basename of the file.

While I understand your use case I am not convinced that this feature is necessary. The benefit is minimal and the effort to implement this robustly for cases like absolute paths is significant. Maybe it is enough to clarify the documentation (

catkin/cmake/catkin_package.cmake

Lines 36 to 51 in 1b2e476

	# :param CFG_EXTRAS: a CMake file containing extra stuff that should
	# be accessible to users of this package after
	# ``find_package``\ -ing it. This file must live in the
	# subdirectory ``cmake`` or be an absolute path. Various additional
	# file extension are possible:
	# for a plain cmake file just ``.cmake``, for files expanded using
	# CMake's ``configure_file()`` use ``.cmake.in`` or for files expanded
	# by empy use ``.cmake.em``. The templates can distinguish between
	# devel- and installspace using the boolean variables ``DEVELSPACE``
	# and ``INSTALLSPACE``. For templated files it is also possible to
	# use the extensions ``.cmake.develspace.(in|em)`` or
	# ``.cmake.installspace.(em|in)`` to generate the files only for a
	# specific case.
	# If the global variable ${PROJECT_NAME}_CFG_EXTRAS is set it will be
	# prepended to the explicitly passed argument.
	# :type CFG_EXTRAS: string

)?

[asmodehn]

I agree it might not be a really needed feature, I did my implementation this way because it worked in devel space.

So I think what got me there, is the difference between the devel space and the install space...
From what I can recall, in the devel space the relative path is kept. But on install space (when building package) it is removed.

The most important would be to get devel and install space behaving consistently, to avoid surprises.

This issue might need more detailed confirmed behavior, I cant recall exactly all details with all changes I did recently...

[dirk-thomas]

devel and install space intentionally behave different. In the case where your extra file is not a template the file is not being copied to the devel space but used from the source space directly. In the install space case the file must be copied though.

I have updated the API documentation to mention that all basenames need to be unique:

• Kinetic b1e138a
• Indigo / Jade 0bd2209