Fix #1825

model_ is destroyed between registration of the single-shot timer and its execution
ros-visualization · May 9, 2024 · e0ec5f6 · e0ec5f6
1 parent b0ca390
commit e0ec5f6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/rviz/properties/property.cpp b/src/rviz/properties/property.cpp
@@ -397,7 +397,10 @@ void Property::setModel(PropertyTreeModel* model)
   if (model_ && hidden_)
   {
     // process propertyHiddenChanged after insertion into model has finished
-    QTimer::singleShot(0, model_, [this]() { model_->emitPropertyHiddenChanged(this); });
+    QTimer::singleShot(0, model_, [this]() {
+      if (model_)
+        model_->emitPropertyHiddenChanged(this);
+    });
   }
   int num_children = numChildren();
   for (int i = 0; i < num_children; i++)