Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Disable test_node to clean CI #901

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Conversation

chapulina
Copy link
Contributor

While the root cause of issue #855 is not figured out, let's disable this test so it's easier to spot regressions on CI.

@chapulina chapulina added the ros2 label Mar 7, 2019
@chapulina
Copy link
Contributor Author

This is just commenting out a test and fixing a small linter error. Merging so that we have a clean CI baseline for other PRs.

@chapulina chapulina merged commit ef83ce6 into crystal Mar 7, 2019
@chapulina chapulina deleted the disable_test_node branch March 7, 2019 21:11
chapulina added a commit to Karsten1987/gazebo_ros_pkgs that referenced this pull request May 22, 2019
chapulina pushed a commit that referenced this pull request May 22, 2019
* [gazebo_ros] use qos

Signed-off-by: Karsten Knese <[email protected]>

* [gazebo_ros] avoid unused warning

Signed-off-by: Karsten Knese <[email protected]>

* [gazebo_plugins] use qos

Signed-off-by: Karsten Knese <[email protected]>

* allow_undeclared_parameters

* fix tests

* forward port pull request #901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant